Turn off file-leak-detector if tests are run with Java 21 #4159
Conversation
See discussion in ome#4158.
|
Discussed earlier today with @dgault and @melissalinkert, the current proposal offers a good compromise allowing to run the non-regression repository tests on JDK 21 without dropping support for JDK 8 yet and still testing file leaks. |
|
Java version should now be logged each time tests are run. As suggested by @dgault, fafc56b picks a different file-leak-detector version based on the JDK version being used. The Ant build changes have been reverted so that file-leak-detector remains enabled. That seems to work locally - I can now both compile and run tests on both 8 and 21. Assuming it also works in the next 4 nightly builds in which it's included, that was easier than I expected and worth considering in the context of ome/ome-common-java#72. |
There was a problem hiding this comment.
Looks good and the nightly CI builds have been running on JDK 8, 11, 17 and 21 with this change included. Only remaining stylistic question is whether we should use something similar to ome/ome-codecs#36 i.e. keep the dependency block in the dependencies and manage a new file-leak-detector.version property via profile.
See discussion in #4158.
Not sure if there is a better way to do this (in particular, to exclude >= 21), but this should at least allow tests to run on Java 21 for now.